-
Notifications
You must be signed in to change notification settings - Fork 47
Max troop lvl / doc fix #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
majordoobie
merged 26 commits into
mathsman5133:g6_2.2.3_candidate
from
doluk:max_troop_lvl
Dec 21, 2022
Merged
Max troop lvl / doc fix #144
majordoobie
merged 26 commits into
mathsman5133:g6_2.2.3_candidate
from
doluk:max_troop_lvl
Dec 21, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Api request update
Cwl fix 2
fix typo
Fixed coc py
…evel, load cls.village
Create FullWarApi.py
wrapperchanges
Fullwarapi public
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including the doc fixing part from #136
Also I added the DataContainer.village attribute as it can be initialized already with the loaded data from json.
This pull requests contains the fix for #143.
It now returns
which should be correct!