Skip to content

Conversation

@av02
Copy link
Contributor

@av02 av02 commented Dec 2, 2022

solving a calender problem that made a 13nd month, and then an exception.

solving a calender problem that made a 13nd month, and then an exception.
@doluk
Copy link
Collaborator

doluk commented Dec 3, 2022

Good find!!
I think we can make it even better.
If I am not wrong, the if in line 357 will always be wrong, so we can remove that part and clean up the rest a bit. Init the month and year ifthey are none, then check for the new year problem while going to the next month and then call get_season_start.

Thank you for the pull request!

@av02
Copy link
Contributor Author

av02 commented Dec 3, 2022

I think you're right.
thank you for your work!

@majordoobie majordoobie self-requested a review December 6, 2022 22:50
@majordoobie
Copy link
Collaborator

Could you post a snippet of the error you were getting please

@majordoobie
Copy link
Collaborator

Doluk clued me in. Thank you for your hard work :)

@majordoobie majordoobie changed the base branch from master to g5_2.2.2_candidate December 6, 2022 23:57
@majordoobie majordoobie merged commit de5b879 into mathsman5133:g5_2.2.2_candidate Dec 6, 2022
@av02 av02 deleted the patch-1 branch December 10, 2022 18:31
@av02 av02 restored the patch-1 branch December 10, 2022 18:32
@majordoobie majordoobie mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants