Adds new clan class fields #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add clan capital league, clan capital trophy points, and the new family friendly field
Collaborator
Kuchenmampfer
left a comment
Kuchenmampfer
left a comment
There was a problem hiding this comment.
Are all those deleted empty lines in license and docstrings intended?
Collaborator
|
I use this in my bots and it works fine. When reading the code, it looks good to me. Except in the removed and re added lines, there are a bunch of unnecessary spaces now. Once you removed them, I would be up to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add clan capital league, clan capital trophy points, and the new family friendly field