Skip to content

Conversation

@jswhit
Copy link

@jswhit jswhit commented May 17, 2012

No description provided.

jswhit pushed a commit that referenced this pull request May 17, 2012
python 3 compatibility fixes (mostly for examples)
@jswhit jswhit merged commit 317000a into matplotlib:master May 17, 2012
@ivanov
Copy link
Member

ivanov commented May 17, 2012

Hi Jeff (peanut gallery comment, just came across this) - is there a reason to not use from __future__ import print_function everywhere? the sys.stdout.write looks a bit awkward.

@jswhit
Copy link
Author

jswhit commented May 17, 2012

sys.stdout.write will work on python 2.5 - but since I'm using the print_function approach in some places, I may as well use it everywhere. I'll change this when I get a chance. Note that this is only for the examples, I'm don't intend to sacrifice python 2.5 compatibility in the module itself.

@ivanov
Copy link
Member

ivanov commented May 17, 2012

ah right, thanks for the explanation, forgot about 2.5. Now I appreciate why once packages start supporting python3, they start to move away from anything older than 2.6, in order to keep their sanity :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants