Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More wx cleanup. #10609

Merged
merged 2 commits into from
Mar 20, 2018
Merged

More wx cleanup. #10609

merged 2 commits into from
Mar 20, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 26, 2018

  1. math.ceil() returns an int on Py3.
  2. Window.SetInitialSize and Window.IsShownOnScreen are documented in
    the wx API; it seems overkill to try to workaround their possible
    absence (that code was present from the very beginning of the git
    history).
  3. the macros attribute is unused since 7499f7c (2004).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
More wx cleanup.
6f358b2 
1) math.ceil() returns an int on Py3.
2) Window.SetInitialSize and Window.IsShownOnScreen are documented in
   the wx API; it seems overkill to try to workaround their possible
   absence (that code was present from the very beginning of the git
   history).
3) the macros attribute is unused since 7499f7c (2004).
@anntzer anntzer added this to the v3.0 milestone Feb 26, 2018
@DietmarSchwertberger DietmarSchwertberger merged commit 1d73e73 into matplotlib:master Mar 20, 2018
@anntzer anntzer deleted the wxmorecleanup branch March 20, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@DietmarSchwertberger DietmarSchwertberger DietmarSchwertberger approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anntzer @timhoffm @DietmarSchwertberger