Deprecate ImageComparisonTest. #10906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Mar 28, 2018
timhoffm
approved these changes
Mar 28, 2018
It's a weird leftover at that point that tries to set up a nose test class but uses pytest markers (via e.g. _checked_on_freetype_version, which uses _knownfailureif, which itself unconditionally relies on pytest) -- basically, it can't actually be used for nose-based testing unless nose somehow learns to interpret pytest markers. A (fairly trivial...) PR has been opened on pytest-mpl to fix their use.
anntzer
force-pushed
the
imagecomparisontest
branch
from
ec45bc3 to
f77735b
Compare
|
rebased, ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a weird leftover at that point that tries to set up a nose test
class but uses pytest markers (via e.g. _checked_on_freetype_version,
which uses _knownfailureif, which itself unconditionally relies on
pytest) -- basically, it can't actually be used for nose-based testing
unless nose somehow learns to interpret pytest markers.
A (fairly trivial...) PR has been opened on pytest-mpl to fix their use:
matplotlib/pytest-mpl#70
PR Summary
PR Checklist