Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis 3.6 builds #12319

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Fix Travis 3.6 builds #12319

merged 1 commit into from
Sep 28, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 28, 2018

PR Summary

We do not need the whole Jupyter stack, and it currently installs packages that do not work with each other. Installing just ipykernel & nbconvert is lighter and avoids the conflict.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.0.x milestone Sep 28, 2018
@QuLogic
Copy link
Member Author

QuLogic commented Sep 28, 2018

I am not certain if this needs backporting to v2.2.x as there hasn't been a new enough build to trigger the problem.

We do not need the whole Jupyter stack, and it currently installs
packages that do not work with each other. Installing just ipykernel and
nbconvert is lighter and avoids the conflict.
@anntzer
Copy link
Contributor

anntzer commented Sep 28, 2018

Merging to unbreak the travis build.

@anntzer anntzer merged commit 495e0bd into matplotlib:master Sep 28, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 28, 2018
dstansby added a commit that referenced this pull request Sep 28, 2018
…319-on-v3.0.x

Backport PR #12319 on branch v3.0.x (Fix Travis 3.6 builds)
@QuLogic QuLogic deleted the fix-travis36 branch September 28, 2018 21:16
@QuLogic
Copy link
Member Author

QuLogic commented Sep 28, 2018

@meeseeksdev backport to v3.0.0-doc

cf #12328

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 28, 2018
@QuLogic QuLogic modified the milestones: v3.0.x, v3.0.0-doc Sep 28, 2018
jklymak added a commit that referenced this pull request Sep 28, 2018
…319-on-v3.0.0-doc

Backport PR #12319 on branch v3.0.0-doc (Fix Travis 3.6 builds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants