Move check for ImageMagick Windows path to bin_path(). #12371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
force-pushed
the
imagemagick-binpath
branch
from
b9fef3a to
bb7a182
Compare
dopplershift
approved these changes
Oct 2, 2018
timhoffm
approved these changes
Oct 3, 2018
|
Travis should be fixed by #12366. Would you mind to rebase? Even though it's a bit cumbersome, I'm feeling more comfortable just merging code with completely passing tests. |
That's a perfectly reasonable place to put the registry check and avoids introducing an additional private helper method.
|
rebased |
anntzer
force-pushed
the
imagemagick-binpath
branch
from
bb7a182 to
59b546f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a perfectly reasonable place to put the registry check and avoids
introducing an additional private helper method.
PR Summary
PR Checklist