Workaround Text3D breaking tight_layout() #12693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Nov 1, 2018
|
This seems fine to me, but a 3-D expert should maybe weigh in? |
|
Can we add a test for this, please? |
tacaswell
previously requested changes
Nov 4, 2018
timhoffm
force-pushed
the
workaround-text3d-breaks-tightlayout
branch
from
a543c4c to
1a5a2cb
Compare
|
Added a test that checks that the order of |
timhoffm
dismissed
tacaswell’s stale review
Dismissing since the test was added.
WeatherGod
approved these changes
Nov 5, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 5, 2018
timhoffm
pushed a commit
that referenced
this pull request
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #12687.
Text3Dused theget_tightbbox()calculation ofText, which is not valid for 3D. This patch reimplementsget_tightbbox()forText3D.For now, we just exclude the text from the layout. This is better than breaking the layout. In the long run, it would be good to get the transform right so that the text is included in the layout calculation.
Note:
Axis3Dcurrently does the same.matplotlib/lib/mpl_toolkits/mplot3d/axis3d.py
Line 460 in ec6a45a