New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround Text3D breaking tight_layout() #12693
Workaround Text3D breaking tight_layout() #12693
Conversation
This seems fine to me, but a 3-D expert should maybe weigh in? |
Can we add a test for this, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on @WeatherGod 's request for a test.
a543c4c
to
1a5a2cb
Compare
Added a test that checks that the order of |
Dismissing since the test was added.
PR Summary
Closes #12687.
Text3D
used theget_tightbbox()
calculation ofText
, which is not valid for 3D. This patch reimplementsget_tightbbox()
forText3D
.For now, we just exclude the text from the layout. This is better than breaking the layout. In the long run, it would be good to get the transform right so that the text is included in the layout calculation.
Note:
Axis3D
currently does the same.matplotlib/lib/mpl_toolkits/mplot3d/axis3d.py
Line 460 in ec6a45a