Skip to content

Inline references to RendererPS in backend_ps. #12872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2018
Merged

Inline references to RendererPS in backend_ps. #12872

merged 1 commit into from
Nov 24, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 23, 2018

Having the additional indirection through _renderer_class doesn't buy us
anything, and e.g. MixedModeRenderer is hard-coded, so heh.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Inline references to RendererPS in backend_ps.
364bad6 
Having the additional indirection through _renderer_class doesn't buy us
anything, and e.g. MixedModeRenderer is hard-coded, so heh.
@QuLogic QuLogic merged commit c167c62 into matplotlib:master Nov 24, 2018
@QuLogic QuLogic added this to the v3.1 milestone Nov 24, 2018
@anntzer anntzer deleted the ps-renderer-class branch November 24, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
backend: ps
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm