Unify checking of executable info. #13303
Conversation
| if not shutil.which("tex"): | ||
| _log.warning("usetex mode requires TeX.") | ||
| return False | ||
| try: |
There was a problem hiding this comment.
We should try all three (even if one fails) so users can know to go install all 3 if they need them, not going to install things one-at-a-time (this is a pet peeve of mine...).
There was a problem hiding this comment.
But this is actually only used as a test marker (for non-test use, we don't run checkdep_usetex and instead just... do whatever is explained in #13285, which you already approved :)), so that doesn't really matter.
lib/matplotlib/__init__.py
Outdated
| Raises | ||
| ------ | ||
| FileNotFoundError | ||
| If the executable is not found or older that the oldest version |
|
I'm not quite sold on the design here, given that each executable basically gets its own check inside the main check. Is that really better than what we have now, and why? Should this be private since its all subject to change anyhow? |
|
The original discussion was in #9571, where there was additionally a single helper for retrieving all infos at once was suggested (and then we would make the all-at-once helper public and the one-at-a-time private). No real strong opinion there; personally the main annoying point IMO is the difference in return value types between the different checkdep_foos (checkdep_ghostscript returns (exec_name, version) whereas the others just return the version. Typo fixed, thanks for noticing it. |
|
IMO this could be private. I don't think we need to provide this functionality as part of our public API. We can still make it public later on should the need arise. |
|
Made the replacement private. |
…303-on-v3.1.x Backport PR #13303 on branch v3.1.x (Unify checking of executable info.)
PR Summary
Supersedes #9639. In particular, an exception is now thrown when the executable exists but is too old, which avoids the issue described in #9639 (comment).
PR Checklist