Prefer mpl.get_data_path(), and support Paths in FontProperties.
#14402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
approved these changes
Jun 3, 2019
lib/matplotlib/afm.py
Outdated
| @@ -13,9 +13,9 @@ | |||
|
|
|||
| It is pretty easy to use, and requires only built-in python libs: | |||
|
|
|||
| >>> from matplotlib import rcParams | |||
| >>> impot matplotlib as mpl | |||
| @@ -0,0 +1,4 @@ | |||
| The *fname* argument to `FontProperties` can now be an `os.PathLike`\s | |||
There was a problem hiding this comment.
What is the \s doing? I don't recognize it.
There was a problem hiding this comment.
The backslash allows you to end intra-word backticks without introducing extra whitespace.
1) Prefer using mpl.get_data_path() rather than rcParams["datapath"]. I would like to ultimately kill that rcParams entry, because it does not make sense as a rcParam (for example one can't really meaningfully assign it to anything else than its default value, or set it in their matplotlibrc) and requires e.g. to be blacklisted in style/core.py; let's start by not using it in the docs. 2) As a side effect of that change, one of the examples (font_file.py) reads a bit more nicely if one can pass Paths to FontProperties, so let's support that.
timhoffm
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer using mpl.get_data_path() rather than rcParams["datapath"].
I would like to ultimately kill that rcParams entry, because it
does not make sense as a rcParam (for example one can't really
meaningfully assign it to anything else than its default value, or
set it in their matplotlibrc) and requires e.g. to be blacklisted
in style/core.py; let's start by not using it in the docs.
As a side effect of that change, one of the examples (font_file.py)
reads a bit more nicely if one can pass Paths to FontProperties, so
let's support that.
PR Summary
PR Checklist