Improve categorical example #15123
Merged
Improve categorical example #15123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is well known that noone likes ham, eggs and spam. So alternatively one could use |
story645
reviewed
Aug 26, 2019
|
Going with the singular fruits. 😄 |
story645
approved these changes
Aug 26, 2019
timhoffm
force-pushed
the
categorical-example
branch
from
c72889f to
1bb9338
Compare
|
Whoops. Messed up the commits. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a purely aesthetic change. The fruit names were a bit long so that they overlap in the bar plot: https://matplotlib.org/devdocs/gallery/lines_bars_and_markers/categorical_variables.html#sphx-glr-gallery-lines-bars-and-markers-categorical-variables-py.
While there are many ways to clean that up, I did not want to introduce additional parameters or commands to keep the example code as simple as possible. So just switching to shorter food names (and making it more pythonesque).