Skip to content

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 11, 2019

Rely on set_positions to set up the relevant arrays, and also numpyfy
it.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should probably be extended a bit to encapsulate vertical orientation in the constructor, since that was buggy here.

@QuLogic
Copy link
Member

QuLogic commented Apr 1, 2020

Ping?

Rely on set_positions to set up the relevant arrays, and also numpyfy
it.
@anntzer
Copy link
Contributor Author

anntzer commented Apr 1, 2020

Sorry, fell off the radar. Extended a test too.

@timhoffm timhoffm merged commit 17ef13b into matplotlib:master Apr 1, 2020
@anntzer anntzer deleted the eventplotinit branch April 1, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants