Skip to content

Deprecate is_pyqt5. #16843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020
Merged

Deprecate is_pyqt5. #16843

merged 1 commit into from
May 5, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 19, 2020

The function won't really make sense anymore after the release of
PyQt6.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Mar 19, 2020
@@ -129,11 +129,10 @@ def _create_qApp():
else:
qApp = app

if is_pyqt5():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the check is redundant with the try... except AttributeError.

@QuLogic
Copy link
Member

QuLogic commented May 5, 2020

Much like the Python 3 transition, do we want to check for >=5 instead? Otherwise, PyQt6 will use the PyQt4 code, but I assume the PyQt6 release will be somewhat closer to the 5 version than 4.

@anntzer
Copy link
Contributor Author

anntzer commented May 5, 2020

sounds good.

The function won't really make sense anymore after the release of
PyQt6.
@timhoffm timhoffm merged commit a45c399 into matplotlib:master May 5, 2020
@anntzer anntzer deleted the is_pyqt5 branch May 5, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants