Skip to content

Small cleanups. #17215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Small cleanups. #17215

merged 1 commit into from
Apr 22, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 22, 2020

  • Saving a couple of attribute lookups in backend_ps is unlikely to
    matter re: performance.
  • _pswriter is a StringIO, not a BytesIO (and the whole module is
    writing strs to it...) so its value will always be a str, not bytes.
  • Trivial cleanups to mathtext.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Small cleanups.
c0a4874 
- Saving a couple of attribute lookups in backend_ps is unlikely to
  matter re: performance.
- _pswriter is a StringIO, not a BytesIO (and the whole module is
  writing strs to it...) so its value will always be a str, not bytes.
- Trivial cleanups to mathtext.
@anntzer anntzer added this to the v3.3.0 milestone Apr 22, 2020
@QuLogic QuLogic merged commit a769d64 into matplotlib:master Apr 22, 2020
@anntzer anntzer deleted the ps branch April 22, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm