Skip to content

Show the failing line in bad-rcparams warnings. #17405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 13, 2020

... and emit all warnings through logging, rather than having one of
them go through print().

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in principle, approval contingent on CI passing.

We have one test that is checking stderr for the file name which will need to be updated.

@tacaswell tacaswell added this to the v3.4.0 milestone May 14, 2020
@anntzer
Copy link
Contributor Author

anntzer commented May 14, 2020

should be fixed now

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but needs a rebase

... and emit all warnings through logging, rather than having one of
them go through `print()`.
@anntzer
Copy link
Contributor Author

anntzer commented May 18, 2020

rebased

@timhoffm
Copy link
Member

Since this is tagged 3.4 I think I cannot merge now?

@QuLogic
Copy link
Member

QuLogic commented May 19, 2020

Four approvals; I don't see why not.

@QuLogic QuLogic merged commit 0c0848b into matplotlib:master May 19, 2020
@QuLogic QuLogic modified the milestones: v3.4.0, v3.3.0 May 19, 2020
@anntzer anntzer deleted the badrc branch May 19, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants