Fold _make_nseq_validator into _listify_validator. #17464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easy to also check the length of the value in _listify_validator; no need to have a second nearly identical "list-validator". Also deprecate validate_nseq_int and validate_nseq_float as a result.
QuLogic
reviewed
May 21, 2020
| @@ -81,18 +81,19 @@ def __call__(self, s): | |||
| raise ValueError(msg) | |||
|
|
|||
|
|
|||
| def _listify_validator(scalar_validator, allow_stringlist=False, *, doc=None): | |||
| @lru_cache() | |||
There was a problem hiding this comment.
Does this get called so much that this cache has an effect?
There was a problem hiding this comment.
I doubt it really matters performance-wise, but e.g. validate_whiskers and validate_sketch create a new listified_validator every time they are called.
QuLogic
approved these changes
May 21, 2020
|
Only marginally related, but as I was looking over usage, I noticed that |
|
yup, fixed as a separate commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to also check the length of the value in _listify_validator;
no need to have a second nearly identical "list-validator". Also
deprecate validate_nseq_int and validate_nseq_float as a result.
PR Summary
PR Checklist