Don't allow 1D lists as subplot_moasic layout. #17938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
approved these changes
Jul 15, 2020
tacaswell
approved these changes
Jul 15, 2020
QuLogic
approved these changes
Jul 15, 2020
|
Sorry I missed this initially. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 15, 2020
QuLogic
added a commit
that referenced
this pull request
Jul 16, 2020
…938-on-v3.3.x Backport PR #17938 on branch v3.3.x (Don't allow 1D lists as subplot_moasic layout.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
plt.subplot_mosaic(['foo', 'bar'])created a layoutwhich is probably surprising, the characters of the inner strings being interpreted as separate specifiers.
This PR chooses the strict solution and prohibits 1D lists of strings and raise a
ValueErrorin this case.Alterantive solution
An alternative solution would be to allow it and create
E.g. we allow the string version to be 1D:
plt.subplot_mosaic('fb')generates plots f and b side-by-side.OTOH we can start with failing and add that feature later if wanted.
ping @tacaswell