Move {get,set}_{x,y}label to _AxesBase. #18421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets SecondaryAxes also use it rather than having to reimplement it (and do so only partially: previously SecondaryAxes did not support the `loc` kwarg).
story645
reviewed
Sep 9, 2020
|
Codecov is fine? |
|
I'm seeing codecov warnings in the review window: |
jklymak
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Yes, this is helpful...
Just to be clear about the codecov - the old code didn't have coverage on those lines either. They just show up because code was moved around. If someone wants to open a new issue about those lines and maybe get someone to write some tests, that would be great. However, I'll merge this as an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets SecondaryAxes also use it rather than having to reimplement it
(and do so only partially: previously SecondaryAxes did not support the
lockwarg).PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).