Skip to content

Conversation

timhoffm
Copy link
Member

PR Summary

The previous styling looked a bit dated and is harder to read.

before / after:
grafik grafik

@timhoffm timhoffm added this to the v3.4.0 milestone Sep 30, 2020
@story645
Copy link
Member

story645 commented Oct 1, 2020

I like but does there even need to be "table of content" or can that just be in a div label or something for screen readers?

@tacaswell
Copy link
Member

Should we leave styling to set the heading color to the blue we use else where?

@timhoffm
Copy link
Member Author

timhoffm commented Oct 1, 2020

@tacaswell Blue color is currently only used for <h1> headings. In particular I would not color the sidebar heading. Quite the opposite, I was considering also removing the color from the sidebar links, because the local toc should be visually restrained.

@story645 IMHO there should be something. I like the pandas-way:

grafik

Anyway, changing the words is a bit more complicated. Currently, they come directly from Sphinx. I suspect, we'd have to vendor our own version of the sidebar template. I'm not sure how far I want to push style changes on the current theme given that we might consider switching to the pydata theme. I'm just picking the lowest hanging fruits with a high annoyance/effort ratio.

@jklymak
Copy link
Member

jklymak commented Oct 1, 2020

Lets merge this, and @story645 if you want to have a follow-on issue, that seems fair. I agree its a bit funny to have such an obvious heading, but...

@jklymak jklymak merged commit 85f6908 into matplotlib:master Oct 1, 2020
@timhoffm timhoffm deleted the css-style branch October 1, 2020 22:00
@timhoffm
Copy link
Member Author

timhoffm commented Oct 1, 2020

... Sphinx wants it that explicit. The PR doesn't change the wording. We can style it white on white 🙃 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants