Skip to content

Fix punctuation in doc. #18987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Conversation

pankajchetry1168
Copy link
Contributor

@pankajchetry1168 pankajchetry1168 commented Nov 20, 2020

PR Summary

  • Replace the open bracket with a comma, following the rest of the sentence's structure, i.e., in that section the number of open and closing parenthesis was of the unequal number as one of the commas might have been typed as "(".

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, but you cannot just drop one of two brackets, and I'm not sure there is any improvement making this a comma.

@pankajchetry1168
Copy link
Contributor Author

pankajchetry1168 commented Nov 21, 2020 via email

@timhoffm timhoffm dismissed jklymak’s stale review November 22, 2020 13:04

This is indeed an unmatched paranthesis.

@timhoffm timhoffm merged commit 3b9ec68 into matplotlib:master Nov 22, 2020
@timhoffm timhoffm added this to the v3.4.0 milestone Nov 22, 2020
@timhoffm
Copy link
Member

Thanks @pankajchetry1168, and congratulations on your first contribution to Matplotlib. We hope to see you again some time.

@jklymak
Copy link
Member

jklymak commented Nov 22, 2020

My apologies, you are correct... Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants