Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: make canonical version stable #19319

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jan 18, 2021

PR Summary

Depends on matplotlib/matplotlib.github.com#47

Makes matplotlib.org/stable the canonical root.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak requested a review from QuLogic January 18, 2021 18:32
@jklymak
Copy link
Member Author

jklymak commented Jan 19, 2021

Added an update of release_guide.rst to explain how to maintain this upon release...

@jklymak
Copy link
Member Author

jklymak commented Jan 23, 2021

I think this is right for now.

It would be nice if "canonical" changed for the newest version of an obsolete page. However, for now I think its best for search engines to try and find it at /stable/

@jklymak jklymak added this to the v3.4.0 milestone Jan 23, 2021
@jklymak
Copy link
Member Author

jklymak commented Jan 23, 2021

If matplotlib/matplotlib.github.com#49 goes in, this will need to be slightly modified

DOC: update developer docs
@jklymak
Copy link
Member Author

jklymak commented Jan 27, 2021

This has been modified to take into account matplotlib/matplotlib.github.com#49

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an SEO expert, but this sounds good.

@tacaswell tacaswell merged commit e0408bb into matplotlib:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants