Dedupe implementations of {XAxis,YAxis}._get_tick_boxes_siblings. #19498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
added
topic: geometry manager
anntzer
force-pushed
the
gtbs
branch
3 times, most recently
from
b5671ea to
24fb288
Compare
timhoffm
reviewed
Feb 11, 2021
A single implementation can be written in the base class. Also, the alignment groupers only need to be defined in FigureBase; we don't need to redefine them in the Figure subclass.
QuLogic
approved these changes
Feb 12, 2021
timhoffm
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single implementation can be written in the base class.
Also, the alignment groupers only need to be defined in FigureBase;
we don't need to redefine them in the Figure subclass.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).