Factor out x/y lo/hi handling in errorbar. #19869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Apr 5, 2021
anntzer
force-pushed
the
errorbarxy
branch
2 times, most recently
from
d68c57f to
db3a8eb
Compare
timhoffm
reviewed
Apr 5, 2021
timhoffm
approved these changes
Apr 6, 2021
lib/matplotlib/axes/_axes.py
Outdated
Comment on lines
3434
to
3435
| io, lo, ho = apply_mask([indep, low, high], nolims & everymask) | ||
| for lho in [lo, ho]: |
There was a problem hiding this comment.
If you can think of better names for io, lo, ho, lho that'd be great. I also don't get what the o is standing for.
indep_masked, low_masked, high_masked may be an option.
There was a problem hiding this comment.
I don't know either, I just reused it from the original version of the code. Agreed that _masked seems fine here.
jklymak
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).