Skip back-and-forth between pixels and points in contour code. #20108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Apr 30, 2021
timhoffm
approved these changes
Apr 30, 2021
👍 I consider removing unneeded public API important. I reduces clutter for users as well as devs. And it makes maintenance and changes easier in the future. |
Text.get_window_extents returns pixels, which get_label_width converts to points, only for all call sites to immediately convert back to pixels. Just introduce a new internal API which uses pixels throughout, and deprecate the old one.
|
Deprecated it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text.get_window_extents returns pixels, which get_label_width converts
to points, only for all call sites to immediately convert back to
pixels. Just introduce a new internal API which uses pixels throughout.
(We could possibly deprecate get_label_width, but heh.)
Edit: get_label_width is deprecated, per the discussion below.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).