DOC: make 2x versions of all gallery figures #20140
Conversation
|
oooh, that worked. I guess the issue is if we want to force devs to download off git. Both those builds took quite a while (23 minutes and 30 minutes). I suspect its a time of day thing: a quick survey of a couple of other PRs range from 18-24 minutes, but I'm not going to guarantee this doesn't slow things down. Compare: NewOld:https://matplotlib.org/stable/gallery/lines_bars_and_markers/barh.html |
|
If we want to push this to the test, we'll have to run the new code. Maybe include a switch so that it only runs on |
Right now circle CI just pip installs from |
|
Use the prerelease for both. It’s sufficient to make the 2x distinction in conf.py. |
|
So, leave it as-is? |
doc/conf.py
Outdated
| @@ -168,6 +168,7 @@ def _check_dependencies(): | |||
| 'thumbnail_size': (320, 224), | |||
| 'compress_images': ('thumbnails', 'images'), | |||
| 'matplotlib_animations': True, | |||
| 'image_srcset': ["2x"], | |||
There was a problem hiding this comment.
Maybe
| 'image_srcset': ["2x"], | |
| # 3.7 CI doc build should not use hidpi images during the testing phase | |
| 'image_srcset': [] if platform.python_version[:3] == '3.7' else ["2x"], |
That way we have builds with and without hidpi images for comparison (ok still using the same code but heh).
There was a problem hiding this comment.
Oh, I see. Sure we can try that.
There was a problem hiding this comment.
You have sys already though: sys.version_info[:2] == (3, 7)
PR Summary
This adds the
image_srcsetparameter to our doc conf.py This will require us to use sphinx-gallery dev version, which I'm not exactly sure how to setup on circleCI.sphinx-gallery/sphinx-gallery#808
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).