Fix wheel builds on CI #20153
Closed
Fix wheel builds on CI #20153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only enabled on the v3.3.x branch, so can be dropped from 3.5, and even 3.4 (but not going to bother).
This is the minimum available for Python 3.8 in wheel form, and should not break ABI to use.
|
Oops, this is from the test branch. |
|
Correct branch is at #20155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The minimum NumPy with Python 3.8 wheels is 1.17.3, so bump CI to use that version. This should be fine since there aren't supposed to be ABI changes in micro releases.
Also drop remnants of 3.6 builds, that are mostly disabled already.
Corresponds to this test build, which is working again
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).