Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline and simplify SubplotToolQt. #20244

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Inline and simplify SubplotToolQt. #20244

merged 1 commit into from
Jun 11, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 16, 2021

Inline the UI setup into the main SubplotToolQt class: it is short
enough that having everything in a single class makes things easier to
follow. Also rework the attributes a bit, replacing _widgets and _attrs
by a single _spinboxes which only tracks spinboxes (and thus attrs), not
buttons.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the doc fixup.

doc/api/next_api_changes/removals/20244-AL.rst Outdated Show resolved Hide resolved
Inline the UI setup into the main SubplotToolQt class: it is short
enough that having everything in a single class makes things easier to
follow.  Also rework the attributes a bit, replacing _widgets and _attrs
by a single _spinboxes which only tracks spinboxes (and thus attrs), not
buttons.
@jklymak jklymak merged commit dc9832a into matplotlib:master Jun 11, 2021
@anntzer anntzer deleted the qtst branch June 11, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants