Skip to content

PGF: Clip lines/markers to maximum LaTeX dimensions. #20410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 11, 2021

PR Summary

This has been open for many years without any change to LaTeX, so it seems unlikely they are going to change how their parsing works.

Note that this does add clipping for filled paths, which we normally don't do, but it's so so far away, I don't think it'll be a problem.

Fixes #4482.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

This has been open for many years without any change to LaTeX, so it
seems unlikely they are going to change how their parsing works.

Fixes matplotlib#4482.
@QuLogic QuLogic added this to the v3.5.0 milestone Jun 11, 2021
@jklymak
Copy link
Member

jklymak commented Jun 11, 2021

I'm surprised that is all there is to it, but if this helps...

@olegrog
Copy link

olegrog commented Dec 24, 2021

@QuLogic Thank you for this fix. However, it is not complete. If I understand correctly, you have clipped markers (in draw_markers) and lines (in _print_pgf_path) only, but there are still some unclipped \pgfsys@transformshift writings. For instance, fill_between with hatching uses this line and can lead to the same Dimension too large error. Could you apply the same clipping technique for that part of the draw_path function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PGF Backend: "Dimension too large" error while processing log-scale plot
4 participants