Make used tex packages consistent between ps and other backends. #20446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe add a test like #10049? |
6 tasks
... by wrapping ps-specific packages in `\@ifpackageloaded`, which makes their use transparent to the end user (if they already loaded it themselves, we don't do anything). So don't mention them anymore in the matplotlibrc docs either. Also, graphicx doesn't need the dvips option (the graphicx docs explicitly state "normally you should... allow it to be defaulted automatically". (The pgf backend is a completely different beast and has its own custom preamble anyways.)
|
sure |
timhoffm
approved these changes
Jun 16, 2021
2 tasks
QuLogic
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by wrapping ps-specific packages in
\@ifpackageloaded, which makestheir use transparent to the end user (if they already loaded it
themselves, we don't do anything). So don't mention them anymore in the
matplotlibrc docs either.
Also, graphicx doesn't need the dvips option (the graphicx docs
explicitly state "normally you should... allow it to be defaulted
automatically".
(The pgf backend is a completely different beast and has its own custom
preamble anyways.)
Closes #10042.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).