Simplify _init_legend_box. #21289
Merged
Simplify _init_legend_box. #21289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reword some comments. Inline `label_prop` to its only use site (previously quite far away from the definition). Rename `lab` to `label`, and some unCamelCasing. Replace the manual splitting-into-columns computation by a single call to np.array_split followed by filtering away empty columns.
timhoffm
approved these changes
Oct 15, 2021
QuLogic
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reword some comments.
Inline
label_propto its only use site (previously quite far away fromthe definition).
Rename
labtolabel, and some unCamelCasing.Replace the manual splitting-into-columns computation by a single call
to np.array_split followed by filtering away empty columns.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).