Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add subplot-mosaic string compact notation #23006

Merged
merged 2 commits into from
May 8, 2022

Conversation

dmatos2012
Copy link
Contributor

PR Summary

This PR would close #22917 which adds a small paragraph to the docs that shows the string compact notation for suplot_mosaic. Additionally, I took the liberty to fix a typo and add a section title to the current tutorial that I believe improves readability a bit.

PR Checklist

Tests and Styling

  • [ N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [ N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor suggestions, so I will not merge it. If someone disagrees with my suggestions, feel free to merge.

Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
@timhoffm timhoffm merged commit bb3519d into matplotlib:main May 8, 2022
@timhoffm
Copy link
Member

timhoffm commented May 8, 2022

Thanks @dmatos2012!

@timhoffm timhoffm added this to the v3.6.0 milestone May 8, 2022
@dmatos2012 dmatos2012 deleted the add-subpltmosaic-docs-notation branch May 9, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ab;cd" missing in subplot_mosaic tutorial
3 participants