Skip to content

Conversation

davidgilbertson
Copy link
Contributor

No description provided.

@QuLogic
Copy link
Member

QuLogic commented May 31, 2022

Please try to make your commit messages more descriptive in the future.

@QuLogic QuLogic merged commit 99e5121 into matplotlib:main May 31, 2022
@QuLogic QuLogic added this to the v3.6.0 milestone May 31, 2022
@davidgilbertson
Copy link
Contributor Author

It's funny you say that, I agonised over what to put. "changed 'uses' to 'use'"? "Fixed typo in [filename]"?

Eventually I figured that a reviewer is not going to know what the change is until they view the changes, so didn't see the point in summarising a literally single-letter change in a way that still wouldn't save you from having to view the changes to know what was actually changed.

If there's guidelines for this sort of thing please let me know and I'll follow them (e.g. describe the change, quantify the change, name the file, etc.).

@oscargus
Copy link
Member

oscargus commented Jun 1, 2022

I think either would do, but in active form, so "change 'uses' to 'use'" or 'Fix typo.' (filename not really required I'd say, of course depending on scenario, but when looking at the blame/history it will be for a particular file anyway). The alternative is "Update gradient_bar.py", so both will be more descriptive.

But I'd also let @QuLogic chip in on this before considering it fully answered. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants