Skip to content

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 18, 2022

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer anntzer added this to the v3.6.0 milestone Jul 18, 2022
@tacaswell
Copy link
Member

When do we make the LatexManager This is moving looking up the pgf command from when we create it to when it is called. Is that going to change any behavior?

@anntzer
Copy link
Contributor Author

anntzer commented Aug 3, 2022

We always access LatexManager via _get_cached_or_new(), which drops the previous LatexManager instance and constructs a new one whenever the texcommand (or the preamble) changes.

@tacaswell tacaswell merged commit 65cbdef into matplotlib:main Aug 3, 2022
@anntzer anntzer deleted the pgflm branch August 3, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants