Skip to content

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 28, 2022

manager_class and _toolbar2_class were correctly set for the webagg and
nbagg subclasses, but the embedding_webagg_sgskip example directly
instantiates a webagg_core manager, so it needs these attributes too.

Fixes the problem noted at #23495 (comment).

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

manager_class and _toolbar2_class were correctly set for the webagg and
nbagg subclasses, but the embedding_webagg_sgskip example directly
instantiates a webagg_core manager, so it needs these attributes too.
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the example!

@oscargus oscargus merged commit d892257 into matplotlib:main Jul 29, 2022
@anntzer anntzer deleted the wc branch July 29, 2022 14:20
@QuLogic QuLogic added this to the v3.6.0 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants