DOC: Rearrange navbar-end elements #23885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mpl_icon_links to the very right, as in the base mpl_sphinx-theme - I would have liked the version-switcher to be on the very left, but somehow the search button is magically added there (note that we have not listed "search-button", but it still shows up). Since I don't have time to dig into that magic now, the minimal-effort reasonable- result change is the order > [search] [theme] [version-dropdown] [links]
timhoffm
added
the
Release critical
|
MRked as release critical because we should get the theme style right for 3.6. |
tacaswell
approved these changes
Sep 15, 2022
|
The failures are the pikepdf wheel issue (I spot-checked 1, expect the rest to be the same). We can ignore than for merging this PR. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 15, 2022
oscargus
added a commit
that referenced
this pull request
Sep 15, 2022
…885-on-v3.6.x Backport PR #23885 on branch v3.6.x (DOC: Rearrange navbar-end elements)
melissawm
pushed a commit
to melissawm/matplotlib
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpl_icon_links to the very right, as in the base mpl_sphinx-theme
I would have liked the version-switcher to be on the very left, but somehow the search button is magically added there (note that we have not listed "search-button", but it still shows up). Since I don't have time to dig into that magic now, the minimal-effort reasonable- result change is the order