Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Qt with PySide6 6.4.0 #24158

Merged
merged 2 commits into from
Oct 15, 2022
Merged

Fix Qt with PySide6 6.4.0 #24158

merged 2 commits into from
Oct 15, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 13, 2022

PR Summary

I also set the "Minimum versions" job to test the minimum supported versions of all the Qt bindings. Due to bugs in PySide2, I had to set its minimum to 5.14 instead of 5.11.2 like PyQt5.

Fixes #24155.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.6.2 milestone Oct 13, 2022
@QuLogic QuLogic force-pushed the fix-qt branch 2 times, most recently from f97180f to 389b45f Compare October 14, 2022 01:03
@QuLogic QuLogic marked this pull request as ready for review October 14, 2022 05:43
@QuLogic QuLogic merged commit c744161 into matplotlib:main Oct 15, 2022
@QuLogic QuLogic deleted the fix-qt branch October 15, 2022 06:31
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 15, 2022
oscargus added a commit that referenced this pull request Oct 15, 2022
…158-on-v3.6.x

Backport PR #24158 on branch v3.6.x (Fix Qt with PySide6 6.4.0)
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: int() argument must be a string, a bytes-like object or a number, not 'KeyboardModifier'
2 participants