Skip to content

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Feb 8, 2023

missing parenthesis introduced in #25145

Reformatted the if block based on a similar set of conditions from the cygwin tests to make it more readable and help locate the error.

I will exercise the unbreak CI one-review merge upon green CI (unless objected to)

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

missing parenthesis introduced in #25145 

Reformatted the if block based on a similar set of conditions from the cygwin tests to make it more readable and help locate the error.

I will exercise the unbreak CI self merge upon green CI (unless objected to)
@ksunden ksunden added the CI: testing CI configuration and testing label Feb 8, 2023
@ksunden ksunden added this to the v3.8.0 milestone Feb 8, 2023
@ksunden ksunden merged commit af8a046 into main Feb 8, 2023
@ksunden ksunden deleted the ksunden-unbreak-tests-workflow branch February 8, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: testing CI configuration and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants