Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate AnchoredEllipse. #25781

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Deprecate AnchoredEllipse. #25781

merged 1 commit into from
Apr 28, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 27, 2023

Needing to construct exactly just an anchored ellipse seems unlikely, and any customization will need accessing the underlying APIs (AnchoredOffsetbox, AuxTransformBox, Ellipse) anyways. Mashing together the parameters of all three constructors is rather awkward, too.

PR Summary

PR Checklist

Linked Issue

  • Added "closes #0000" in the PR description to link it to the original issue.

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer anntzer added this to the v3.8.0 milestone Apr 27, 2023
@anntzer
Deprecate AnchoredEllipse.
20c3c56 
Needing to construct exactly just an anchored ellipse seems unlikely,
and any customization will need accessing the underlying APIs
(AnchoredOffsetbox, AuxTransformBox, Ellipse) anyways.  Mashing together
the parameters of all three constructors is rather awkward, too.
@QuLogic QuLogic merged commit 0022f42 into matplotlib:main Apr 28, 2023
@anntzer anntzer deleted the ae branch April 28, 2023 08:52
@anntzer anntzer mentioned this pull request Jun 19, 2023
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anntzer @QuLogic @timhoffm