Emit explanatory exception when no temporary cachedir can be created. #25840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A warning is already emitted when a temporary cachedir is created; it seems reasonable to also explain the situation when no cachedir can be created at all. Also note that in these cases the directory really only serves as cache, not as configdir (there won't be user-defined configs there), so adjust the message accordingly.
tacaswell
approved these changes
May 9, 2023
ksunden
approved these changes
May 9, 2023
|
Anyone can merge on Green CI (modulo tk problems on azure macos which are known) |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 9, 2023
…orary cachedir can be created.
ksunden
added a commit
that referenced
this pull request
May 9, 2023
…840-on-v3.7.x Backport PR #25840 on branch v3.7.x (Emit explanatory exception when no temporary cachedir can be created.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning is already emitted when a temporary cachedir is created; it seems reasonable to also explain the situation when no cachedir can be created at all. Also note that in these cases the directory really only serves as cache, not as configdir (there won't be user-defined configs there), so adjust the message accordingly.
Closes #25838.
PR summary
PR checklist