Doc: Updates default value for nonpositve parameter for semilogx and semilogy #25982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of nonpositive is falsely documented as 'mask' instead of 'clip'. This was fixed for the loglog function but needed to be fixed for semilogx and semilogy as well.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
QuLogic
approved these changes
May 25, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 25, 2023
…ve parameter for semilogx and semilogy
|
Thanks @pettza! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
QuLogic
added a commit
that referenced
this pull request
May 26, 2023
…982-on-v3.7.x Backport PR #25982 on branch v3.7.x (Doc: Updates default value for nonpositve parameter for semilogx and semilogy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Issue #25758 was about a falsely documented default value in
loglogfunction and mentioned that this must be an issue with other functions as well. Another PR #25776 fixed this only for the loglog function. This PR addresses semilogx and semilogy as well.