Skip to content

macos: Don't leak None in Timer cleanup #26424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jul 31, 2023

PR summary

I noticed this when reviewing some other PR at some point. It doesn't have a huge impact because None is a singleton that is never freed, but maybe has consequences in other implementations (PyPy?).

PR checklist

@greglucas greglucas added this to the v3.8.0 milestone Aug 1, 2023
@greglucas greglucas merged commit 654213e into matplotlib:main Aug 1, 2023
@QuLogic QuLogic deleted the macos-none branch August 1, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants