Import PIL.Image explicitly over PIL #26490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We seem to use `PIL.Image.*` pretty often while only importing `PIL`. This mostly works, but seems to be by fluke depending on what may or may not have imported `PIL.Image`. For example, if you have a file that just does `import matplotlib.widgets` (which itself imports only `PIL`), then `mypy` will crash due to incomplete `PIL`.
ksunden
approved these changes
Aug 11, 2023
story645
approved these changes
Aug 13, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 13, 2023
ksunden
added a commit
that referenced
this pull request
Aug 14, 2023
…490-on-v3.8.x Backport PR #26490 on branch v3.8.x (Import PIL.Image explicitly over PIL)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
We seem to use
PIL.Image.*pretty often while only importingPIL. This mostly works, but seems to be by fluke depending on what may or may not have importedPIL.Imagebeforehand.For example, if you have a file that just does
import matplotlib.widgets(which itself imports onlyPIL), thenmypywill crash due to incompletePIL.PR checklist