Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Revise histogram features example (Closes #26604) #26606

Merged
merged 4 commits into from
Aug 26, 2023

Conversation

jsdodge
Copy link
Contributor

@jsdodge jsdodge commented Aug 26, 2023

PR summary

Remove reference to IQ scores and "Smarts" in figure; modify distribution parameters; update RNG syntax. Closes #26604.

PR checklist

Remove reference to IQ scores and "Smarts" in figure; modify distribution parameters; update RNG syntax
@jsdodge jsdodge marked this pull request as draft August 26, 2023 06:08
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@jsdodge jsdodge marked this pull request as ready for review August 26, 2023 07:42
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @jsdodge. I agree about IQ scores being problematic, and it is also good to modernise the numpy handling.

@rcomer rcomer added this to the v3.8-doc milestone Aug 26, 2023
@rcomer rcomer merged commit f9f673f into matplotlib:main Aug 26, 2023
21 checks passed
@rcomer
Copy link
Member

rcomer commented Aug 26, 2023

Congratulations on your first PR in Matplotlib @jsdodge! We hope to hear from you again.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 26, 2023
timhoffm added a commit that referenced this pull request Aug 26, 2023
…606-on-v3.8.x

Backport PR #26606 on branch v3.8.x ([Doc] Revise histogram features example (Closes #26604))
@QuLogic QuLogic modified the milestones: v3.8-doc, v3.8.0 Aug 28, 2023
@ksunden ksunden mentioned this pull request Sep 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Inappropriate example in gallery
3 participants