-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test_contour under test_datetime.py #27013
Add test_contour under test_datetime.py #27013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Modify test_contour matplotlib#26864
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having 6 instead of 3 plots is slightly unnecessary (Z does not actually go through units behavior, and both Z values are just floats anyway)
But it looks correct and is testing what we want to test here.
Thank you @kots14
@ksunden Thank you for your feedback and for approving the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the extra 3 Axes could be removed if you're making updates.
You mean from these lines shall I remove 3?
|
The last three (and get rid of the variables that become unused as a result). |
Thanks @kots14! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
Attempting adding code for
test_contour
method intest_datetime.py
mentioned in #26864Image output -
![test_datetime_contour](https://private-user-images.githubusercontent.com/20207952/273155379-644bdb80-a832-489a-af82-ddfc314c8d0d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4NTc1OTAsIm5iZiI6MTcyMzg1NzI5MCwicGF0aCI6Ii8yMDIwNzk1Mi8yNzMxNTUzNzktNjQ0YmRiODAtYTgzMi00ODlhLWFmODItZGRmYzMxNGM4ZDBkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE3VDAxMTQ1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk4MmVlZmUzNDQzMGI3YmU5NjNlMDRmYmI2NTI1OWM5MTlkMmM1MzAwMjEyNzI5MzQ4OWM1MjcwYWE4Y2Y0NDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1Ede_4l5yJFkq1-JfGWhQ2mkCeT7EtfmBD1NAlww6OA)
PR checklist