Skip to content

Conversation

costaparas
Copy link
Contributor

PR summary

Fix typo in error message, add more detail and make formatting consistent

PR checklist

Fix typo in error message, add more detail and make formatting consistent
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @costaparas! I agree this is better.

@story645
Copy link
Member

Thanks for the PR!

Code coverage error is related - these lines aren't tested, but I think codecover is only picking them up now b/c they haven't been changed since we introduced code cover.

Would you be interested in writing tests to check that these error messages get triggered?

@costaparas
Copy link
Contributor Author

Thanks for the PR!

Code coverage error is related - these lines aren't tested, but I think codecover is only picking them up now b/c they haven't been changed since we introduced code cover.

Would you be interested in writing tests to check that these error messages get triggered?

Yes, added. Thanks.

@story645 story645 added this to the v3.10.0 milestone Sep 23, 2024
@story645 story645 merged commit 65878f3 into matplotlib:main Sep 23, 2024
43 checks passed
@story645
Copy link
Member

Congrats on your first merged PR, thanks for also putting in the tests, and we hope to see you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants