Skip to content

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 20, 2024

PR summary

This works around actions/runner-images#10984

PR checklist

@QuLogic QuLogic added the CI: testing CI configuration and testing label Nov 20, 2024
@QuLogic QuLogic added this to the v3.10.0 milestone Nov 20, 2024
Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with one review (unbreak CI) merge once tests finish here. (The part that this affects has passed, but actual tests are still running)

@QuLogic QuLogic merged commit ed1ba66 into matplotlib:main Nov 21, 2024
44 of 46 checks passed
@QuLogic QuLogic deleted the macos-pkgconf branch November 21, 2024 04:48
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 21, 2024
ksunden pushed a commit that referenced this pull request Nov 21, 2024
…29164)

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
ksunden pushed a commit to ksunden/matplotlib that referenced this pull request Nov 22, 2024
…on macOS (matplotlib#29164)

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic
Copy link
Member Author

QuLogic commented Nov 23, 2024

@meeseeksdev backport to v3.9.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 23, 2024
QuLogic added a commit that referenced this pull request Nov 23, 2024
…163-on-v3.9.x

Backport PR #29163 on branch v3.9.x (ci: Remove outdated pkg-config package on macOS)
@jayaddison
Copy link
Contributor

@QuLogic I think that this can be reverted now; I've been inspecting this part of the code as part of #29732, and as a result have read this comment that I believe means all should be clear again in the updated runner images: actions/runner-images#10984 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: testing CI configuration and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants