Skip to content

Handled non finite values in ax.pie - issue #29860 #29873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
Merged

Handled non finite values in ax.pie - issue #29860 #29873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a129589
handled non finite values in ax.pie
AdarshDec Apr 6, 2025
a5c1d34
Merge remote-tracking branch 'upstream/main' into bugfix/29860-handle…
AdarshDec Apr 12, 2025
5ddcb77
adressed pr review
AdarshDec Apr 12, 2025
ca40674
removed white spaces
AdarshDec Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3303,6 +3303,9 @@ def pie(self, x, explode=None, labels=None, colors=None,
if np.any(x < 0):
raise ValueError("Wedge sizes 'x' must be non negative values")

if not np.all(np.isfinite(x)):
raise ValueError('Wedge sizes must be finite numbers')

sx = x.sum()

if normalize:
Expand Down
8 changes: 8 additions & 0 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9720,3 +9720,11 @@ def test_bar_shape_mismatch():
)
with pytest.raises(ValueError, match=error_message):
plt.bar(x, height)


def test_pie_non_finite_values():
fig, ax = plt.subplots()
df = [5, float('nan'), float('inf')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
df = [5, float('nan'), float('inf')]
values = [5, float('nan'), float('inf')]

Optional. df is typically used as variable name for dataframes, so it's slightly misleading here.


with pytest.raises(ValueError, match='Wedge sizes must be finite numbers'):
ax.pie(df, labels=['A', 'B', 'C'])
Loading