Skip to content

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Aug 27, 2025

PR summary

sanitize_sequence does not convert everything to a sequence. It specifically only converts MappingView objects. So, for example, it you pass an int to _replacer you get an int back.

I had reason to worry about this for my proposed changes in #29152

PR checklist

@rcomer rcomer added this to the v3.11.0 milestone Aug 27, 2025
@story645 story645 merged commit 671c032 into matplotlib:main Aug 27, 2025
33 of 35 checks passed
@story645
Copy link
Member

Oops, this may have needed two reviews since it's docs in code vs docs in docs 🤦‍♀️

@rcomer
Copy link
Member Author

rcomer commented Aug 27, 2025

Thanks @story645! I think this falls under

not fundamental and can easily be reverted at any time in the future

https://matplotlib.org/devdocs/devel/pr_guide.html#merging

So I reckon we're good 🙂

@rcomer rcomer deleted the replacer-docstring branch August 27, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants